-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags to channels #314
Draft
proof-of-reality
wants to merge
41
commits into
cryptosharks131:v1.9.0
Choose a base branch
from
proof-of-reality:feature/add-tags-to-channels
base: v1.9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add tags to channels #314
proof-of-reality
wants to merge
41
commits into
cryptosharks131:v1.9.0
from
proof-of-reality:feature/add-tags-to-channels
+570
−419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration 0037 ensures each setting is available in settings table
proof-of-reality
commented
Aug 6, 2023
proof-of-reality
commented
Aug 7, 2023
This allows splitting multiple configurations into multiple groups
Get default LNDg settings instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to manage channels in a bulk
*Nice to have for future versions:
Features/rules added with this:
A
from LNDg group to a new groupG
, channelA
is removed from groupLNDg
A
to a new groupH
,A
will belong to groupG
andH
simultaneouslyA
from groupH
andG
,A
will return toLNDg
1.1. It's allowed to create a group for
AR
and another forAF
1.2. It's allowed to split
AR
orAF
into further more groups with the condition of: channelA
cannot be in groupG
andH
if both groups have a single setting in common. Say:G->AR-Time:5
andH->AR-Time:2
(except Enabled settings)1.3. In contrast to 1.2 if you add some channels to a rebalancer group
G
but do NOT assign any rebalance settings to it, the rebalancer will act as if none of these channels were assigned to the newly created group and will get AR settings fromLNDg
instead. (The rebalance would get triggered with theLNDg
default settings)1.4. GUI/LND settings and AR-Workers are owned by
LNDg
group. (can be changed in the future)Summary: Any group settings can be split into multiple groups if and only if channels within those same groups doesnt share any common setting